Fix regression in nondeterministic failure of overlay services#620
Merged
Fix regression in nondeterministic failure of overlay services#620
Conversation
ethanjli
changed the title
Collaborator
Author
|
I've tested this with two first-time boots after re-flashing SD card images and with three reboots (without re-flashing in between reboots), and I haven't seen the behavior described in #618 (comment) - so I think this PR solves the problem, at least on my end. @sonnyp: since the problem seems to manifest more nondeterministically for me (in such a way that I still haven't been able to reproduce a larger failure resulting in loss of machine-name generation functionality), could you please check if this PR solves the |
sonnyp
approved these changes
May 22, 2025
Collaborator
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Thanks.
I couldn't reproduce with this. Confirmed twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the problem described in #618 (comment) (and analyzed in #618 (comment)), which may be a regression caused by #613.