fix(ses): emit result node in SES v1 Query-protocol write responses#1926
Merged
Conversation
The SES v1 (Query/XML) protocol always wraps a response in a
`<{Action}Result>` element, empty for actions with no output members. The
`xml_metadata_only` helper emitted only `<{Action}Response>` +
`<ResponseMetadata>` with no result node, so the AWS SDK failed to deserialize
every no-output SES v1 write action with "{Action}Result node not found" --
e.g. CreateConfigurationSet, the verify/delete/set identity actions, etc.
Emit an empty `<{Action}Result/>` node (via query_response_xml with an empty
body) so the response matches the protocol shape. This unblocks the apply path
for the SES v1 acceptance tests (they previously errored at create); the
remaining per-resource SES v1 gaps -- deterministic verification tokens, the
v1 identity delete/notification state model, receipt-rule wiring, configuration
set last_fresh_start / reputation options -- are separate follow-ups, so SES v1
is not yet wired into the tfacc harness.
Owning-crate unit test asserts the result node is present.
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SES v1 (Query/XML) protocol always wraps a response in a
<{Action}Result>element -- empty for actions with no output members. Thexml_metadata_onlyhelper emitted only<{Action}Response>+<ResponseMetadata>with no result node, so the AWS SDK failed to deserialize every no-output SES v1 write action with "{Action}Result node not found" (e.g.CreateConfigurationSet, the verify/delete/set identity actions).This emits an empty
<{Action}Result/>node (viaquery_response_xmlwith an empty body) so the response matches the protocol shape. It unblocks the apply path for the SES v1 acceptance tests, which previously errored at the very first create.The remaining per-resource SES v1 gaps -- deterministic verification tokens, the v1 identity delete/notification state model, receipt-rule wiring, configuration-set
last_fresh_start/ reputation options -- are separate follow-ups, so SES v1 is not yet wired into the tfacc harness (it would be red). This PR is the foundational correctness fix that every SES v1 write action needed.No new public API surface (response-shape correctness fix).
Test plan
v1_write_action_response_includes_result_nodeasserts the result node is present.cargo test -p fakecloud-ses(251 pass),cargo clippy --all-targets -D warnings,cargo fmtclean.Summary by cubic
Ensure SES v1 Query responses include an empty <{Action}Result> node for no-output write actions. This fixes AWS SDK deserialization errors and lets actions like CreateConfigurationSet proceed.
xml_metadata_onlyto usequery_response_xmlwith an empty body, emitting<{Action}Result/>as required by the protocol.v1_write_action_response_includes_result_nodeto verify the result node is present.Written for commit 780fdd6. Summary will update on new commits.