fix(glue,autoscaling): GetTables Expression filter + SetDesiredCapacity bounds#2004
Merged
Conversation
2026-06-27 bug-hunt 1.19: - Glue GetTables now applies Expression as a regex filter on the table name (GetPartitions already honored its Expression, so GetTables ignoring it was inconsistent). - CloudWatch DescribeAlarms honors AlarmTypes: when omitted it returns only metric alarms (composite alarms must be requested explicitly), instead of always emitting composites. - AutoScaling SetDesiredCapacity rejects a desired capacity outside [MinSize, MaxSize] with a ValidationError, as AWS does. Tests: e2e for Glue Expression + CW AlarmTypes; unit test for the ASG bound (scale-to-0 requires lowering MinSize first; out-of-range is rejected).
…x + AWS model) The existing composite_alarm_in_describe_alarms test asserted DescribeAlarms returns composites by default; the cloudwatch.json model says "if you omit AlarmTypes, only metric alarms are returned, even if composite alarms exist." Request AlarmTypes=CompositeAlarm to see the composite, and assert it is absent without it.
# Conflicts: # crates/fakecloud-e2e/tests/glue.rs
…ances e2e The new SetDesiredCapacity [MinSize,MaxSize] bound (AWS-correct) rejects desired=0 on a group with MinSize=1; update MinSize to 0 first, as a real client must.
…e contradicts) The cloudwatch_composite_alarm conformance test asserts DescribeAlarms returns a composite alarm by default; rather than change behavior an AWS-derived test relies on without real-AWS verification, drop the AlarmTypes filtering and keep only the Glue Expression + ASG bound fixes in this PR.
vieiralucas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-06-27 bug-hunt Tier 1 finding 1.19 (Glue + ASG).
Expressionas a regex filter on the table name (GetPartitions already honored its Expression).[MinSize, MaxSize]with aValidationError, as AWS does.Note: the DescribeAlarms AlarmTypes change originally in this PR was reverted — the
cloudwatch_composite_alarmconformance test asserts composites are returned by default, and I won't change behavior an AWS-derived test relies on without real-AWS verification (the model doc says metric-only, but conformance is truth here).Tests: e2e for Glue Expression; unit + real-instances e2e for the ASG bound (scale-to-0 lowers MinSize first; out-of-range rejected).