fix(bedrock): validate TagResource ARN, add embed schema, fix profanity and deployments#277
Merged
vieiralucas merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
…ty matching, deployment names - Reject empty/missing resourceARN in TagResource with ValidationException - Return embedding vector schema for amazon.titan-embed models instead of text-gen schema - Use word-boundary matching for profanity detection to prevent false positives - Serialize non-string hyperparameter values instead of silently converting to empty string - Generate unique deployment names when modelDeploymentName is not provided
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/fakecloud-bedrock/src/invoke.rs">
<violation number="1" location="crates/fakecloud-bedrock/src/invoke.rs:181">
P2: Use a Titan-embedding-specific prefix check instead of `contains("embed")` to avoid returning embedding schema for unrelated model IDs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resourceARNin TagResource with ValidationException instead of storing tags under empty keyamazon.titan-embed-*models instead of text-generation schemamodelDeploymentNameis not providedAddresses unresolved Cubic findings from PRs #260, #266.
Test plan
cargo clippy -p fakecloud-bedrock -- -D warningspassesSummary by cubic
Fixes correctness and robustness in
fakecloud-bedrock: validatesTagResourceARN, returns proper Titan embed schema across variants, improves profanity checks, and hardens deployment/hyperparameter handling. Addresses remaining Cubic findings from earlier PRs.TagResourceresourceARN; returnValidationExceptionwhen missing or empty.amazon.titan-embed*models (prefix match) instead of text-generation.modelDeploymentNameis not provided.Written for commit 6ef8765. Summary will update on new commits.