refactor: extract shared Query protocol helpers to fakecloud-core#281
Merged
vieiralucas merged 1 commit intomainfrom Apr 12, 2026
Merged
refactor: extract shared Query protocol helpers to fakecloud-core#281vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
- Add fakecloud_core::query module with query_response_xml(), query_metadata_only_xml(), optional_query_param(), and required_query_param() - Migrate SQS, ElastiCache, RDS, SES v1 xml_wrap() to delegate to core - Migrate ElastiCache, RDS optional_param/required_param to delegate to core - Make SQS md5_hex/sha256_hex pub(crate) instead of pub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fakecloud_core::querymodule with shared Query protocol XML wrapping (query_response_xml,query_metadata_only_xml) and param extraction (optional_query_param,required_query_param)xml_wrap()copies and 2 identicaloptional_param/required_parampairsmd5_hex/sha256_hexpub(crate)since they're only used within the crateTest plan
cargo clippy --workspace --all-targets -- -D warningspasses cleanxml_wrap_produces_valid_responsetest in ElastiCache still passesSummary by cubic
Extracted shared AWS Query protocol helpers into
fakecloud-coreand updatedfakecloud-sqs,fakecloud-elasticache,fakecloud-rds, andfakecloud-ses(v1) to use them. Removes duplicate XML wrappers and parameter parsing; no behavior change intended.Refactors
fakecloud_core::query::{query_response_xml, query_metadata_only_xml, optional_query_param, required_query_param}.xml_wrap()and param helpers in the services to delegate to core.fakecloud-sqsmd5_hex/sha256_hextopub(crate)as they are internal utilities.Migration
fakecloud-sqs::md5_hexorsha256_hex, switch tomd5/sha2directly or copy the small helpers.Written for commit 7610253. Summary will update on new commits.