fix(kinesis): add input validation for CreateStream, DeleteStream, ListStreams#286
Merged
vieiralucas merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
…stStreams - Validate StreamName length (1-128) in require_stream_name and resolve_stream_name - Validate ExclusiveStartStreamName length (1-128), NextToken min length, and Limit range (1-100) in ListStreams - Fixes 6 failing conformance variants (negative_too_long_StreamName, negative_too_short/too_long_ExclusiveStartStreamName, negative_above_max_Limit, negative_too_short_NextToken)
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateStreamandDeleteStreamExclusiveStartStreamName(1-128),NextToken(min 1), andLimit(1-100) validation toListStreamsTest plan
cargo test -p fakecloud-kinesis— all unit tests passcargo clippy -p fakecloud-kinesis— cleanSummary by cubic
Add strict input validation to Kinesis
CreateStream,DeleteStream, andListStreamsto match AWS behavior and prevent invalid requests. Fixes six failing conformance variants and brings all 14 Kinesis ops infakecloud-kinesisto 100% conformance.Bug Fixes
StreamNamelength 1–128 inCreateStream/DeleteStreamand helpers.ListStreamsparams:ExclusiveStartStreamName1–128,NextTokenmin 1,Limit1–100.ListStreamsdefaultLimitto 100.Refactors
cargo fmtfor code formatting.Written for commit 93d8f91. Summary will update on new commits.