refactor: use selective tokio features and fix blocking fs in async#296
Merged
vieiralucas merged 1 commit intomainfrom Apr 12, 2026
Merged
refactor: use selective tokio features and fix blocking fs in async#296vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
- Replace tokio features = ["full"] with explicit feature list (macros, rt-multi-thread, net, io-util, time, signal, sync, process, fs) to avoid pulling in unused features - Wrap extract_zip() call in spawn_blocking to avoid blocking the async runtime during Lambda container cold start ZIP extraction
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokio = { features = ["full"] }with explicit feature set to avoid unnecessary dependenciesextract_zip()inspawn_blockingto avoid blocking the async runtime during Lambda container cold startsTest plan
cargo clippy --workspace --all-targets -D warningscleanextract_zipunit test passesSummary by cubic
Tightened
tokiofeatures to only what's needed and moved ZIP extraction to a blocking task to keep the async runtime responsive during Lambda cold starts.Dependencies
tokio = { features = ["full"] }with explicit features:macros,rt-multi-thread,net,io-util,time,signal,sync,process,fs.Bug Fixes
extract_zip()intokio::task::spawn_blockingto avoid blocking the async runtime during container setup.Written for commit fce0663. Summary will update on new commits.