refactor(rds): name the arguments to db_instance_xml's format string#317
Merged
vieiralucas merged 1 commit intomainfrom Apr 13, 2026
Merged
refactor(rds): name the arguments to db_instance_xml's format string#317vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
``db_instance_xml`` builds the XML body for a single ``DescribeDBInstances``
entry. The format string at the bottom takes twenty-eight positional
arguments that a reader has to mentally align with the ``{}`` holes in a
thirty-line template. Verifying that a particular field lands in the
right tag requires counting.
Switches to named format arguments. ``<MultiAZ>{multi_az}</MultiAZ>`` is
self-explanatory now; the rest of the positional list becomes a labeled
binding block. Also lifts the inline ``latest_restorable_time``
``.map().unwrap_or_default()`` chain out of the argument list into a
named variable alongside the other pre-built XML fragments, for
consistency with ``db_name_xml`` / ``vpc_security_groups_xml`` / etc.
No output change. All 1102 unit tests still pass.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db_instance_xmlbuilds the XML body for a singleDescribeDBInstancesentry. The format string at the bottom used twenty-eight positional arguments aligned with{}holes in a thirty-line template. Verifying that a particular field lands in the right tag required counting.This PR switches to named format arguments so that
<MultiAZ>{multi_az}</MultiAZ>is self-explanatory and the positional list becomes a labeled binding block. Also lifts the inlinelatest_restorable_time.map().unwrap_or_default()chain out of the argument list into a named variable, for consistency with the other pre-built XML fragments (db_name_xml,vpc_security_groups_xml, etc.).No output change.
Test plan
cargo build --workspacecargo fmt --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --exclude fakecloud-e2e --exclude fakecloud-conformance— 1102 passed, 0 failedSummary by cubic
Refactored
fakecloud-rdsXML builder to use named format arguments indb_instance_xmland extractedlatest_restorable_timeinto a variable. Improves readability and reduces mistakes; no output change.format!args with named bindings (e.g.,<MultiAZ>{multi_az}</MultiAZ>).latest_restorable_timemapping intolatest_restorable_time_xmlalongside other prebuilt fragments.Written for commit e1c28b6. Summary will update on new commits.