refactor(stepfunctions): extract apply_state_catcher helper#332
Merged
vieiralucas merged 1 commit intomainfrom Apr 13, 2026
Merged
refactor(stepfunctions): extract apply_state_catcher helper#332vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
The fallible states in run_states (Task, Parallel, Map) each had the same 18-line block for handling an execution error: read the Catch array off the state def, ask find_catcher for a matching clause, build an Error/Cause JSON, run apply_result_path, and advance to the chosen next state — or propagate the error if no clause matched. Move that into apply_state_catcher, returning Option<(next_state, new_effective_input)>. The three call sites shrink from ~15 lines each to a 7-line match. Behaviour unchanged.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fallible states in `run_states` (`Task`, `Parallel`, `Map`) each had the same 18-line block for handling an execution error: read the `Catch` array off the state def, ask `find_catcher` for a matching clause, build an `Error`/`Cause` JSON, run `apply_result_path`, and advance to the chosen next state — or propagate the error if no clause matched.
Move that into `apply_state_catcher`, returning `Option<(next_state, new_effective_input)>`. The three call sites shrink from ~15 lines each to a 7-line match. Behaviour unchanged.
Test plan
Summary by cubic
Extracted
apply_state_catcherto centralizeCatchhandling forTask,Parallel, andMapstates in the Step Functions interpreter. This removes duplicate error-handling blocks, simplifiesrun_states, and keeps behavior unchanged (returnsOption<(next_state, new_effective_input)>).Written for commit 0075587. Summary will update on new commits.