refactor(eventbridge): bundle fire_rule context refs into FireRuleContext#350
Merged
vieiralucas merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
…text fire_rule took 7 positional args (state + delivery + lambda_state + logs_state + container_runtime + bus_name + rule_name). Bundle the five that are 'where the surrounding services live' into FireRuleContext<'a>; keep bus_name and rule_name as regular params since they're the actual lookup keys. Same shape as the SNS TopicFanoutContext from PR #344. Updates the three unit tests and the server's /_fakecloud/eventbridge/ fire-rule handler call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`fire_rule` took 7 positional args (state + delivery + lambda_state + logs_state + container_runtime + bus_name + rule_name). Bundle the five that are "where the surrounding services live" into a borrowed `FireRuleContext<'a>`; keep `bus_name` and `rule_name` as regular params since they're the actual lookup keys, not context. Same shape as the SNS `TopicFanoutContext` from PR #344.
Updates the three unit tests in `simulation.rs` and the server's `/_fakecloud/eventbridge/fire-rule` handler in `main.rs` to construct the context inline.
Test plan
Summary by cubic
Bundled the environment args for
fire_ruleinto a borrowedFireRuleContextto simplify call sites and match the SNSTopicFanoutContext. No behavior changes.FireRuleContext<'a>; keptbus_nameandrule_nameas parameters./_fakecloud/eventbridge/fire-rulehandler to construct the context inline.Written for commit b9fc560. Summary will update on new commits.