refactor(secretsmanager): extract CreateSecretInput from create_secret#360
Merged
vieiralucas merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
create_secret inlined body parsing, field validation, and struct construction in ~140 lines. Extract a CreateSecretInput struct with a from_body() constructor that owns the validation + field extraction, so create_secret is ~110 lines focused on idempotency, ARN construction, and version/secret assembly.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_secretinlined body parsing, field validation, and struct construction in ~140 lines. Extract aCreateSecretInputstruct with afrom_body()constructor that owns validation + field extraction, socreate_secretis ~110 lines focused on idempotency, ARN construction, and version/secret assembly.Test plan
cargo clippy -p fakecloud-secretsmanager --all-targets -- -D warningscargo test -p fakecloud-secretsmanager(39 passed)Summary by cubic
Refactored
create_secretinfakecloud-secretsmanagerto extract request parsing and validation into a dedicatedCreateSecretInput, making the handler shorter and clearer with no behavior changes.CreateSecretInputwithfrom_body()to own field extraction, validation, base64 decoding, and tag parsing.create_secretto use the new input, focusing on idempotency checks, ARN construction, and version assembly.Written for commit 5a9107b. Summary will update on new commits.