Skip to content

feat(tfacc): enable bedrock with foundation models data source#379

Merged
vieiralucas merged 1 commit intomainfrom
worktree-tfacc-ses-cfn
Apr 14, 2026
Merged

feat(tfacc): enable bedrock with foundation models data source#379
vieiralucas merged 1 commit intomainfrom
worktree-tfacc-ses-cfn

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Apr 14, 2026

Summary

Batch 10 — adds Bedrock to the upstream Terraform acceptance harness.

`TestAccBedrockFoundationModelsDataSource_basic` passes against fakecloud out of the box. fakecloud's Bedrock implementation already returns the expected `ListFoundationModels` shape.

Triaged but deferred

Several other services were triaged in this batch but each needs substantive fakecloud-side work bigger than a single-batch budget:

  • SES v2 — `TestAccSESV2EmailIdentity_basic_emailAddress` needs the verification flow rewired so new identities default to unverified (real AWS doesn't auto-verify email addresses), plus `current_signing_key_length` empty by default and `tokens` empty for email-address identities. Existing fakecloud e2e tests assume auto-verify, so fixing this needs both the impl change and updates to the e2e suite.
  • CloudFormation — needs `AWS::EC2::VPC` resource type in the CFN provisioner.
  • Cognito — needs ~5 schema blocks populated on `DescribeUserPool`.
  • RDS — needs `DescribeOrderableDBInstanceOptions`.
  • Lambda — needs EC2 `DescribeAvailabilityZones`.
  • Step Functions — depends on Lambda; `SFNActivity` needs `CreateActivity`.
  • S3 — needs many fields populated (`bucket_regional_domain_name`, `hosted_zone_id`, `region`, etc).

Each gets its own batch as the underlying gaps close.

Test plan

  • Upstream locally: `TestAccBedrockFoundationModelsDataSource_basic` passes (~6s)
  • `cargo clippy -p fakecloud-tfacc --all-targets -- -D warnings` clean
  • CI `tfacc bedrock` green
  • All other tfacc jobs still green
  • Cubic clean

Summary by cubic

Enable Bedrock acceptance in fakecloud-tfacc by running the data.aws_bedrock_foundation_models data source test against fakecloud. This adds the bedrock service to the allowlist and a test; ListFoundationModels is already supported, so the smoke test passes.

  • New Features
    • Allowlist bedrock with regex ^TestAccBedrockFoundationModelsDataSource_basic$.
    • Add bedrock_acceptance test to run the service in the tfacc harness.

Written for commit ece004e. Summary will update on new commits.

Batch 10: TestAccBedrockFoundationModelsDataSource_basic passes
against fakecloud out of the box. fakecloud's Bedrock implementation
already returns the expected ListFoundationModels shape.

SES, RDS, Cognito, S3, CloudFormation, Lambda, and Step Functions
all triaged in this batch but each needs substantive fakecloud-side
work (verification flow, DescribeOrderableDBInstanceOptions, ~5 schema
blocks, EC2 surface, etc) that's bigger than this batch's wall-time
budget. Each gets its own batch as the underlying gaps close.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@vieiralucas vieiralucas merged commit 1f1c4ad into main Apr 14, 2026
35 checks passed
@vieiralucas vieiralucas deleted the worktree-tfacc-ses-cfn branch April 14, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant