docs(seo): address Cubic findings on SEO landings#684
Merged
vieiralucas merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
- `test-lambda-locally.md`: fix runtime list to match actually-supported set (13 total) — drop Python 3.9/3.10, Java 11, .NET 6, Ruby 3.2, Go; add Python 3.13, Ruby 3.3/3.4. - `mock-dynamodb.md`: point DynamoDB docs link to `/docs/services/dynamodb/` instead of the services index. - `blog/cdk-local-testing.md` + `blog/terraform-local-development-aws.md`: add an explicit `curl -sf` after the health-wait loop so the CI step fails when fakecloud never becomes ready (the bare `for … && break; sleep` loop exits 0 on timeout). - `blog/terraform-local-development-aws.md`: add the missing `output "bucket_id"` block so the documented `terraform output -raw bucket_id` command actually works as copy-pasted.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 5 Cubic review findings across the recent SEO batch:
test-lambda-locally.md: the "All 13 AWS Lambda runtimes" bullet listed 15+ entries that didn't match what fakecloud actually ships. Replaced with the real supported set (Node 18/20/22, Python 3.11/3.12/3.13, Java 17/21, .NET 8, Ruby 3.3/3.4,provided.al2/provided.al2023) — 13 total, matchingcrates/fakecloud-lambda/src/runtime.rs.mock-dynamodb.md: "DynamoDB docs" link pointed to the services index (/docs/services/) instead of the DynamoDB page (/docs/services/dynamodb/).blog/cdk-local-testing.md+blog/terraform-local-development-aws.md(2x): thefor i in \$(seq 1 30); do curl -sf … && break; sleep 1; donehealth-wait loop exits 0 even when fakecloud never becomes ready (the finalsleep 1is the loop's exit status). Added a trailingcurl -sfso the CI step fails explicitly on timeout.blog/terraform-local-development-aws.md: the sample command used\$(terraform output -raw bucket_id)but nooutput "bucket_id"block was defined. Added the missing output so the documented flow works as copy-pasted.Test plan
crates/fakecloud-lambda/src/runtime.rs(13 entries match)./docs/services/dynamodb/confirmed to exist (website/content/docs/services/dynamodb.md).Summary by cubic
Fixes five SEO-related doc issues found by Cubic across four pages. Updates the Lambda runtime list, corrects a DynamoDB link, hardens CI health checks, and adds a missing Terraform output.
test-lambda-locally.md: Replace runtime list with the actual 13 supported runtimes — Node 18/20/22; Python 3.11/3.12/3.13; Java 17/21; .NET 8; Ruby 3.3/3.4;provided.al2/provided.al2023.mock-dynamodb.md: Point “DynamoDB docs” to/docs/services/dynamodb/.blog/cdk-local-testing.mdandblog/terraform-local-development-aws.md: Add a trailingcurl -sfafter the wait loop so CI fails if fakecloud never becomes ready.blog/terraform-local-development-aws.md: Addoutput "bucket_id"to match the documentedterraform output -raw bucket_id.Written for commit 9b75eae. Summary will update on new commits.