fix(conformance): address Cubic findings from PR #688#689
Merged
vieiralucas merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Three P3 findings slipped into main because the Cubic `AI code reviewer` CI check had already reported SUCCESS; the findings landed as inline review comments, not as a failed check. - `rds_modify_db_parameter_group`: ModifyDBParameterGroup's Smithy input requires `Parameters` — the test was sending a call the Smithy model rejects as invalid. Add a realistic Parameter (max_connections=100, apply_method=pending-reboot). - website/content/vs/floci.md, vs/ministack.md: comparison tables still said "Smithy-validated, 54k+ test variants"; bump to 57k+ to match the rest of the site.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #688 merged before its Cubic review comments were read (check conclusion was SUCCESS, which only means the reviewer finished — it does not mean zero findings). Three valid P3 issues:
crates/fakecloud-conformance/tests/rds.rs:ModifyDBParameterGroupSmithy input requiresParameters; the test was omitting it. Send a realistic Parameter.website/content/vs/floci.md+vs/ministack.md: comparison tables still said "Smithy-validated, 54k+ test variants" while the surrounding prose moved to 57k+.Test plan
cargo check --tests -p fakecloud-conformancecargo fmt --checkgrep -r "54k\|54,000" website/content/vs/returns nothingSummary by cubic
Addresses Cubic findings from PR #688. Fixes the RDS ModifyDBParameterGroup conformance test to include the required
Parameters(setsmax_connections=100,apply_method=pending-reboot) and updates comparison tables inwebsite/content/vs/floci.mdandwebsite/content/vs/ministack.mdto 57k+ test variants.Written for commit a552ed0. Summary will update on new commits.