ci(codecov): relax patch target to 50% for conformance batches#709
Merged
vieiralucas merged 1 commit intomainfrom Apr 23, 2026
Merged
ci(codecov): relax patch target to 50% for conformance batches#709vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
Many net-new ops in the conformance batches are protocol shims exercised via crates/fakecloud-conformance/tests/* (excluded from coverage) rather than unit tests. A flat 50% target keeps the patch gate honest for real new code without blocking those batches.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by cubic
Set Codecov patch coverage target to 50% to avoid false failures from conformance batches where protocol shims are only exercised via excluded tests, while keeping the gate meaningful for real changes. Updated codecov.yml to replace patch default target "auto" with "50%".
Written for commit 1d071e4. Summary will update on new commits.