Skip to content

ci(codecov): relax patch target to 50% for conformance batches#709

Merged
vieiralucas merged 1 commit intomainfrom
worktree-codecov-relax
Apr 23, 2026
Merged

ci(codecov): relax patch target to 50% for conformance batches#709
vieiralucas merged 1 commit intomainfrom
worktree-codecov-relax

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Apr 23, 2026

Summary

  • Net-new ops in the in-flight conformance batches are protocol shims that get exercised through the conformance test harness (under crates/fakecloud-conformance/tests/, excluded from coverage), so codecov/patch's auto target ends up unreachable.
  • Drop patch target to a flat 50%, keeping the gate honest for real new code without blocking the protocol-shim batches.

Test plan

  • N/A (config-only change)

Summary by cubic

Set Codecov patch coverage target to 50% to avoid false failures from conformance batches where protocol shims are only exercised via excluded tests, while keeping the gate meaningful for real changes. Updated codecov.yml to replace patch default target "auto" with "50%".

Written for commit 1d071e4. Summary will update on new commits.

Many net-new ops in the conformance batches are protocol shims
exercised via crates/fakecloud-conformance/tests/* (excluded from
coverage) rather than unit tests. A flat 50% target keeps the
patch gate honest for real new code without blocking those batches.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vieiralucas vieiralucas merged commit 831ae62 into main Apr 23, 2026
42 checks passed
@vieiralucas vieiralucas deleted the worktree-codecov-relax branch April 23, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant