feat(apigatewayv2): align path routing + JSON case with Smithy model#712
Merged
vieiralucas merged 1 commit intomainfrom Apr 23, 2026
Merged
feat(apigatewayv2): align path routing + JSON case with Smithy model#712vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
- Smithy says routing rules nest under a domain
(/v2/domainnames/{name}/routingrules), sharing policies are
/sharingpolicy (no hyphen), portal product pages are /productpages
and /productrestendpointpages (one word, not hyphenated), and
DisablePortal is DELETE /v2/portals/{id}/publish (not POST /disable).
Reroute all of these in resolve_action + conformance tests +
extras handlers.
- Smithy serializes apigatewayv2 response fields in camel-case
(jsonName defaults first-letter-lowercase). Extras handlers emit
Pascal-case for legibility; add a to_camel walker that runs on
every response + a body reader that merges Pascal-case duplicates
of incoming camel-case fields so handlers read either case.
- Bumps baseline apigateway probe coverage from 76.1% to 83.1%
and overall conformance to 99.2%. Remaining apigwv2 variants
need per-op response-shape enrichment (Smithy-required fields
like portalDefaultDomainName, lastModified, etc.); tracked as
follow-up.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v2/domainnames/{name}/routingrules, sharing policies are/sharingpolicy, portal product pages are/productpagesand/productrestendpointpages, DisablePortal isDELETE /v2/portals/{id}/publish).apiId,lastModified, …). Extras handlers emit Pascal-case; add ato_camelwalker on every response and a body reader that merges Pascal-case duplicates of incoming camel-case fields, so handlers can stay Pascal-case-friendly.apigatewayprobe coverage from 76.1% -> 83.1% and overall variants from 98.9% -> 99.2%.Test plan
cargo test -p fakecloud-conformance --test apigatewayv2(7 passing)cargo run -p fakecloud-conformance -- audit(PASS, 1702/1702)cargo clippy --workspace --all-targets -- -D warnings(clean)Summary by cubic
Aligns
fakecloud-apigatewayv2path routing and camelCase JSON with the Smithy model to match AWS and boost conformance coverage./v2/domainnames/{DomainName}/routingrules(create/list/get/put/delete)./sharingpolicy(no hyphen)./productpagesand/productrestendpointpages(no hyphens).DELETE /v2/portals/{id}/publish(notPOST /disable).fakecloud-conformance).Written for commit 530d9b6. Summary will update on new commits.