Skip to content

feat(apigatewayv2): strip summary-only fields from Create/Update#714

Merged
3 commits merged intomainfrom
worktree-apigwv2-shape-fix-2
Apr 23, 2026
Merged

feat(apigatewayv2): strip summary-only fields from Create/Update#714
3 commits merged intomainfrom
worktree-apigwv2-shape-fix-2

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Apr 23, 2026

Summary

  • Product pages / rest endpoint pages store a pageTitle / endpoint string for the Smithy Summary shapes, but the Create/Update response shapes don't carry them. Stash them under _summary_* in storage and strip on response; list_subresources reads the stashed value.
  • Translate incoming EndpointDisplayContent (None, Overrides) to the EndpointDisplayContentResponse (Body, Endpoint, OperationName) rather than echoing input.
  • Lifts the apigateway probe baseline from 92.2% -> 95.6% and overall conformance from 99.6% -> 99.8%.

Stacked on top of #713. Merge that one first.

Test plan

  • cargo test -p fakecloud-conformance --test apigatewayv2 (7 passing)
  • cargo clippy --workspace --all-targets -- -D warnings (clean)
  • cargo run -p fakecloud-conformance -- audit (PASS, 1702/1702)

Summary by cubic

Aligns API Gateway v2 extras with Smithy response shapes for Create/Update/Get and List. Stashes summary-only fields in storage, strips them from responses, translates inputs to the correct outputs, adds required defaults, and lifts conformance (apigateway 92.2% → 95.6%, overall 99.6% → 99.8%).

  • Refactors
    • Product pages and REST endpoint pages: stash _summary_* fields; strip on Create/Update/Get; List projects to Summary shapes (PageTitle/Endpoint).
    • Translate EndpointDisplayContent to EndpointDisplayContentResponse (Body, Endpoint, OperationName); default Endpoint to page id when missing.
    • Build Portal/PortalProduct responses from known Smithy fields; drop unknown inputs.
    • Add defaults/required fields: IntegrationResponseKey/RouteResponseKey$default; include DomainNameArn, ApiMappingSelectionExpression, RoutingMode; add RoutingRuleArn and default Priority; include MutualTlsAuthentication only if set; rename ListRoutingRules wrapper to RoutingRules; include model Description only when provided.

Written for commit 4169b63. Summary will update on new commits.

…onses

- Product pages and rest endpoint pages store a pageTitle /
  endpoint for Smithy Summary shapes, but the CreateProductPage /
  UpdateProductPage / CreateProductRestEndpointPage /
  UpdateProductRestEndpointPage response shapes don't carry them.
  Stash them under a '_summary_*' prefix in storage and strip on
  response; list_subresources reads the stashed value.
- Translate EndpointDisplayContent (input: None, Overrides) to
  EndpointDisplayContentResponse (output: Body, Endpoint,
  OperationName) rather than echoing input.
- Lifts the apigateway probe baseline from 92.2% -> 95.6% and
  overall conformance from 99.6% -> 99.8%.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/fakecloud-apigatewayv2/src/extras.rs 0.00% 36 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="crates/fakecloud-apigatewayv2/src/extras.rs">

<violation number="1" location="crates/fakecloud-apigatewayv2/src/extras.rs:1073">
P2: `_summary_endpoint` is populated with the resource ID, so list summaries can return the wrong endpoint value.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread crates/fakecloud-apigatewayv2/src/extras.rs
@vieiralucas vieiralucas closed this pull request by merging all changes into main in b6e791e Apr 23, 2026
@vieiralucas vieiralucas deleted the worktree-apigwv2-shape-fix-2 branch April 23, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant