feat(apigatewayv2): strip summary-only fields from Create/Update#714
Merged
3 commits merged intomainfrom Apr 23, 2026
Merged
Conversation
…onses - Product pages and rest endpoint pages store a pageTitle / endpoint for Smithy Summary shapes, but the CreateProductPage / UpdateProductPage / CreateProductRestEndpointPage / UpdateProductRestEndpointPage response shapes don't carry them. Stash them under a '_summary_*' prefix in storage and strip on response; list_subresources reads the stashed value. - Translate EndpointDisplayContent (input: None, Overrides) to EndpointDisplayContentResponse (output: Body, Endpoint, OperationName) rather than echoing input. - Lifts the apigateway probe baseline from 92.2% -> 95.6% and overall conformance from 99.6% -> 99.8%.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/fakecloud-apigatewayv2/src/extras.rs">
<violation number="1" location="crates/fakecloud-apigatewayv2/src/extras.rs:1073">
P2: `_summary_endpoint` is populated with the resource ID, so list summaries can return the wrong endpoint value.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…pigwv2-shape-fix-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageTitle/endpointstring for the Smithy Summary shapes, but the Create/Update response shapes don't carry them. Stash them under_summary_*in storage and strip on response;list_subresourcesreads the stashed value.EndpointDisplayContent(None, Overrides) to theEndpointDisplayContentResponse(Body, Endpoint, OperationName) rather than echoing input.apigatewayprobe baseline from 92.2% -> 95.6% and overall conformance from 99.6% -> 99.8%.Stacked on top of #713. Merge that one first.
Test plan
cargo test -p fakecloud-conformance --test apigatewayv2(7 passing)cargo clippy --workspace --all-targets -- -D warnings(clean)cargo run -p fakecloud-conformance -- audit(PASS, 1702/1702)Summary by cubic
Aligns API Gateway v2 extras with Smithy response shapes for Create/Update/Get and List. Stashes summary-only fields in storage, strips them from responses, translates inputs to the correct outputs, adds required defaults, and lifts conformance (apigateway 92.2% → 95.6%, overall 99.6% → 99.8%).
_summary_*fields; strip on Create/Update/Get; List projects to Summary shapes (PageTitle/Endpoint).EndpointDisplayContenttoEndpointDisplayContentResponse(Body, Endpoint, OperationName); defaultEndpointto page id when missing.Portal/PortalProductresponses from known Smithy fields; drop unknown inputs.IntegrationResponseKey/RouteResponseKey→$default; includeDomainNameArn,ApiMappingSelectionExpression,RoutingMode; addRoutingRuleArnand defaultPriority; includeMutualTlsAuthenticationonly if set; rename ListRoutingRules wrapper toRoutingRules; include modelDescriptiononly when provided.Written for commit 4169b63. Summary will update on new commits.