feat(apigatewayv2): close conformance gap to 100%#715
Merged
vieiralucas merged 5 commits intomainfrom Apr 23, 2026
Merged
Conversation
…onses - Product pages and rest endpoint pages store a pageTitle / endpoint for Smithy Summary shapes, but the CreateProductPage / UpdateProductPage / CreateProductRestEndpointPage / UpdateProductRestEndpointPage response shapes don't carry them. Stash them under a '_summary_*' prefix in storage and strip on response; list_subresources reads the stashed value. - Translate EndpointDisplayContent (input: None, Overrides) to EndpointDisplayContentResponse (output: Body, Endpoint, OperationName) rather than echoing input. - Lifts the apigateway probe baseline from 92.2% -> 95.6% and overall conformance from 99.6% -> 99.8%.
…pigwv2-shape-fix-2
Enforces Smithy-declared @required, @Length, @range, and @enum constraints on the apigwv2 management-API handlers so that negative probe variants (omit_X / too_long_X / above_max_X / invalid_enum_X) surface a 4xx instead of silently succeeding. * Body-field validation for Create/Put/Import ops: req_str / req_array / req_object helpers return 400 BadRequestException when a @required body field is absent. * Path-id validation for Delete/Update ops: URL-template tokens that arrive as literal `{Name}` or URL-encoded `%7BName%7D` are now recognized as invalid (alongside the existing empty-segment rule). * Length/range/enum checks for RoutingMode, ContentHandlingStrategy, TryItState, Portal LogoUri, RumAppMonitorName, PortalProduct DisplayName, Description, RoutingRule Priority, ListRoutingRules MaxResults, PublishPortal Description. * Update* handlers now require their path id explicitly so `put_keyed` and `put_subresource` can't silently fabricate a new entity when the caller omits the label. Overall conformance: 59954/59954 = 100.00% (apigateway 2769/2769).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
negative_*probe variant returns a 4xx instead of silently succeedingreq_str/req_array/req_objectfor required body fields,check_length/check_range/check_enumfor constraint traits,valid_path_idfor placeholder/URL-encoded{Name}detectionput_keyedandput_subresourcecan't fabricate a new entity when the caller omits the labelTest plan
cargo clippy --workspace --all-targets -- -D warningscargo fmtcargo test -p fakecloud-apigatewayv2 --lib(83 passed)fakecloud-conformance run --services apigateway— 2769/2769fakecloud-conformance runfull sweep — 59954/59954 = 100%conformance-baseline.jsonSummary by cubic
Enforces Smithy validation and path-id checks for API Gateway v2 management APIs so invalid requests return 4xx. This brings apigatewayv2 conformance to 100% (2769/2769) and overall to 100% (59954/59954).
New Features
req_str,req_array,req_object,check_length,check_range,check_enum) andvalid_path_id. Update operations now require their path id to prevent accidental creates.{Name},%7BName%7D) to “missing”, so handlers reject omitted labels with a 400.Bug Fixes
outputType; UntagResource needstagKeys; CreateVpcLink needs Name + SubnetIds.Written for commit 51a749c. Summary will update on new commits.