feat(elbv2): scaffold Elastic Load Balancing v2 — LoadBalancers + Tags#746
Merged
vieiralucas merged 5 commits intomainfrom Apr 25, 2026
Merged
feat(elbv2): scaffold Elastic Load Balancing v2 — LoadBalancers + Tags#746vieiralucas merged 5 commits intomainfrom
vieiralucas merged 5 commits intomainfrom
Conversation
First batch of ELBv2 (Application/Network/Gateway Load Balancer) support.
- New crate `fakecloud-elbv2` wired into server registry under SigV4 service
name `elasticloadbalancing` (Query protocol, XML responses).
- 12 ops: CreateLoadBalancer, DescribeLoadBalancers, DeleteLoadBalancer,
SetSubnets, SetSecurityGroups, SetIpAddressType, ModifyIpPools, AddTags,
RemoveTags, DescribeTags, DescribeAccountLimits, DescribeSSLPolicies.
- Real Smithy validation: name length/chars, internal- prefix rejection,
Type/Scheme/IpAddressType enums; idempotent CreateLoadBalancer matching
AWS's documented behavior; cascade-delete listeners/rules on
DeleteLoadBalancer.
- Introspection endpoints: /_fakecloud/elbv2/{load-balancers,target-groups,
listeners,rules}.
- TS + Python SDKs: Elbv2Client + dataclass types.
- 12 conformance tests with Smithy shape checksums + 7 unit tests.
- aws-models/elasticloadbalancingv2.json + service-map entry.
- README + website /local-elb/ landing page + llms.txt updates.
- Subsequent batches: target groups, listeners, rules, attributes/trust
stores, real HTTP routing, ECS auto-register.
aab10ef to
dd06d02
Compare
There was a problem hiding this comment.
3 issues found across 26 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="website/static/llms.txt">
<violation number="1" location="website/static/llms.txt:8">
P3: The updated service list now includes 26 services, but the nearby headline still says 23 services / 1,680 operations, so this section is internally inconsistent.</violation>
</file>
<file name="crates/fakecloud-elbv2/src/service.rs">
<violation number="1" location="crates/fakecloud-elbv2/src/service.rs:439">
P2: Validate `IpAddressType` in `CreateLoadBalancer`; invalid values are currently accepted and stored.</violation>
<violation number="2" location="crates/fakecloud-elbv2/src/service.rs:658">
P2: `SetSubnets` should validate `IpAddressType` before updating state.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…txt counts - CreateLoadBalancer / SetSubnets now reject invalid IpAddressType up-front via shared validate_ip_address_type helper (was already enforced in SetIpAddressType only). - llms.txt headline updated from 23 services / 1,680 ops to 26 / 1,810 to match the post-ELBv2 service list directly below it.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Apr 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First batch of ELBv2 (Application/Network/Gateway Load Balancer) support — picks up the Wave 4 roadmap slot after ECR + ECS shipped.
fakecloud-elbv2wired into server under SigV4 serviceelasticloadbalancing. Wire protocol: AWS Query, XML responses (matching real ELBv2).CreateLoadBalancer,DescribeLoadBalancers,DeleteLoadBalancer,SetSubnets,SetSecurityGroups,SetIpAddressType,ModifyIpPools,AddTags,RemoveTags,DescribeTags,DescribeAccountLimits,DescribeSSLPolicies.application,network,gateway) — ARN prefix matches AWS conventions (app/,net/,gwy/); idempotentCreateLoadBalancer; cascade-delete listeners/rules onDeleteLoadBalancer; tags routing across every taggable resource.internal-prefix rejection,Type/Scheme/IpAddressTypeenum constraints — returnsValidationErrorwith the AWS-shaped error envelope.Introspection
GET /_fakecloud/elbv2/load-balancersGET /_fakecloud/elbv2/target-groupsGET /_fakecloud/elbv2/listenersGET /_fakecloud/elbv2/rulesSDKs
Elbv2Client(fc.elbv2.getLoadBalancers()etc.)Elbv2Client+_SyncElbv2Client+ dataclass typesDocs
website/content/local-elb.mdlanding pagewebsite/static/llms.txtupdatedelasticloadbalancing+ ECR/ECS entriesRoadmap
Subsequent batches: target groups + targets + health, listeners + rules, attributes + trust stores + capacity reservations, real in-process HTTP routing + ECS auto-register-target.
Test plan
cargo test -p fakecloud-elbv2— 7 unit tests passcargo test -p fakecloud-conformance --test elbv2— 12 Smithy-checksum-validated tests passcargo build --testsworkspace cleancargo clippy --workspace --all-targets -- -D warningscleancargo fmt --all -- --checkcleanSummary by cubic
Adds first batch of ELBv2 support (ALB/NLB/GWLB) for Load Balancers and Tags under SigV4
elasticloadbalancing. Ships 12 core ops with Smithy-accurate validation, SDKs, and introspection.New Features
fakecloud-elbv2(AWS Query, XML) wired into the server.application,network,gatewaytypes with correct ARN prefixes (app/,net/,gwy/); idempotent create; cascade-delete listeners/rules.internal-prefix, enum constraints) returning AWS-shapedValidationError./_fakecloud/elbv2/{load-balancers,target-groups,listeners,rules}.Elbv2Client+ types; testkitelbv2_client(); conformance wired viaaws-sdk-elasticloadbalancingv2.website/content/local-elb.md; addedaws-models/elasticloadbalancingv2.json+ service-map entry.Bug Fixes
IpAddressTypevalidation inCreateLoadBalancerandSetSubnetsvia a shared helper (was only inSetIpAddressType).Elbv2Clientcode.website/static/llms.txtheadline counts to 26 services / 1,810 ops.validate_ip_address_typehelper.Written for commit 0d472ab. Summary will update on new commits.