feat(cloudfront): legacy Streaming Distributions (RTMP) — full CRUD#783
Merged
vieiralucas merged 2 commits intomainfrom Apr 26, 2026
Merged
feat(cloudfront): legacy Streaming Distributions (RTMP) — full CRUD#783vieiralucas merged 2 commits intomainfrom
vieiralucas merged 2 commits intomainfrom
Conversation
7 new ops: Create/CreateWithTags/Get/GetConfig/Update/Delete/List with ETag/If-Match concurrency, CallerReference uniqueness, and the StreamingDistributionNotDisabled rule enforced before delete (matches AWS behavior for the legacy resource). cloudfront 93 -> 100, total 2,141 -> 2,148. 4 E2E tests + 7 conformance tests (Smithy checksums); audit clean (cloudfront 101/101 covered).
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/fakecloud-cloudfront/src/streaming_service.rs">
<violation number="1" location="crates/fakecloud-cloudfront/src/streaming_service.rs:221">
P2: Deleting a streaming distribution leaves its tags behind in `account.tags`, so `ListTagsForResource` can still return tags for a deleted resource.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Cubic finding: account.tags is keyed by ARN, so removing the streaming distribution from streaming_distributions but not its ARN entry from tags leaves orphaned tags that ListTagsForResource would still return. E2E regression: tags exist after CreateStreamingDistributionWithTags, absent after DeleteStreamingDistribution.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create,CreateWithTags,Get,GetConfig,Update,Delete,ListCallerReferenceuniqueness on createDeleteStreamingDistributionenforcesStreamingDistributionNotDisabled(matches AWS)Test plan
cargo test -p fakecloud-e2e --test cloudfront_streaming— 4 lifecycle tests passFAKECLOUD_RUN_CONFORMANCE=1 cargo test -p fakecloud-conformance --test cloudfront_streaming— 7 conformance tests passcargo run -p fakecloud-conformance -- audit— cloudfront 101/101 coveredcargo clippy --workspace --all-targets -- -D warningscleancargo fmt --allcleanSummary by cubic
Adds full support for CloudFront Streaming Distributions (legacy RTMP), including CRUD and tagging, with AWS-accurate concurrency and delete rules. CloudFront now has 100 ops (project total 2,148), and docs are updated.
New Features
CallerReferencemust be unique on create.Enabled=true(StreamingDistributionNotDisabled), matching AWS.Bug Fixes
DeleteStreamingDistributionnow clears tags for the distribution ARN to prevent orphaned tags inListTagsForResource.Written for commit b9e42cd. Summary will update on new commits.