test(dispatch): cover streaming_route path-style and virtual-hosted S3#789
Merged
vieiralucas merged 1 commit intomainfrom Apr 26, 2026
Merged
test(dispatch): cover streaming_route path-style and virtual-hosted S3#789vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
Codecov flagged 0% patch coverage on the virtual-hosted branch added in PR #788. This adds 8 unit tests covering: - Path-style PutObject `/bucket/key` - Path-style CreateBucket `/bucket` (must skip streaming) - Virtual-hosted PutObject `/key` with bucket in Host header - Virtual-hosted root `/` (CreateBucket, must skip) - ECR OCI v2 PATCH and PUT blob uploads - Presigned V4 S3 PUT - Non-S3 SigV4 auth header (must skip) - GET method (must skip)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codecov flagged 0% patch coverage on the virtual-hosted branch added in #788. Adds 8 unit tests for
streaming_routecovering both the new code path and the surrounding logic.Cases:
/bucket/key-> streaming/bucket-> buffered (no slash after bucket)/key(bucket in Host) -> streaming (the new branch)/-> buffered (CreateBucket on virtual-hosted endpoint)Test plan
cargo test -p fakecloud-core --lib streaming_route-> 8/8 passSummary by cubic
Add 8 unit tests for
streaming_routeto cover S3 path-style and virtual-hosted PUTs, ECR blob uploads, and presigned S3 PUT. Verifies streaming only for PUT/PATCH uploads and skips CreateBucket, non-S3 SigV4, and GET, restoring coverage for the new virtual-hosted branch.Written for commit 63b8122. Summary will update on new commits.