fix(rds): forward fmt + SDK e2e poll fixes from PR #808#809
Merged
vieiralucas merged 2 commits intomainfrom Apr 28, 2026
Merged
fix(rds): forward fmt + SDK e2e poll fixes from PR #808#809vieiralucas merged 2 commits intomainfrom
vieiralucas merged 2 commits intomainfrom
Conversation
CreateDBInstance now returns a `creating` placeholder; the introspection endpoint reports the populated container_id/host_port only after the background container start completes. Add an explicit poll loop in both SDK e2e tests so they wait up to 4 minutes for the status to flip before asserting.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #808 auto-merged before its trailing fmt + SDK e2e fix commits landed. Forward both:
cargo fmtcollapse on the persistence-load creating-instance scrub.availablebefore asserting populated container_id/host_port (CreateDBInstance now returns acreatingplaceholder per refactor(rds): make CreateDBInstance async, drop 180s SDK timeout #808).Test plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningsSummary by cubic
Forwards missed fixes from PR #808: formats the RDS creating-instance scrub and updates SDK e2e tests to wait for instances to be ready before asserting container fields.
Bug Fixes
CreateDBInstance(now returns acreatingplaceholder), pollDescribeDBInstancesup to 4 minutes until statusavailable, then assertcontainer_idandhost_port.Refactors
cargo fmtcollapse in the RDS creating-instance scrub filter closure.Written for commit 18e751c. Summary will update on new commits. Review in cubic