feat: transparent leader hint reconnect on consume#2
Merged
vieiralucas merged 3 commits intomainfrom Mar 24, 2026
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main/java/dev/faisca/fila/FilaClient.java">
<violation number="1" location="src/main/java/dev/faisca/fila/FilaClient.java:122">
P1: Validate and constrain `x-fila-leader-addr` before redirecting; the current code can forward authenticated consume requests (including API key auth) to an arbitrary address from server metadata.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
97b4767 to
8f9f2c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consume()receives gRPCUNAVAILABLEwithx-fila-leader-addrtrailing metadata, the SDK transparently creates a new connection to the leader address and retries the consume call onceTest plan
./gradlew compileJava)./gradlew test)x-fila-leader-addrmetadata are still raised asRpcExceptionSummary by cubic
Adds transparent leader redirect for
consume()when a follower returns gRPCUNAVAILABLEwithx-fila-leader-addr. Retries once against the hinted leader, reusing TLS and API key settings.New Features
UNAVAILABLEwithx-fila-leader-addr, reconnects to the leader and resumes the stream once.ApiKeyInterceptoron the redirected channel; extracts channel-building helpers and makesBuilder.parseHost/parsePortreusable.UNAVAILABLEwithout a leader hint still throws the mappedRpcException;CANCELLEDexits quietly.Bug Fixes
host:port, numeric port 1–65535); invalid hints fail fast.spotlessformatting (no behavior change).Written for commit 04a421f. Summary will update on new commits.