refactor: switch admin ops from protobuf to binary encoding#10
Merged
vieiralucas merged 1 commit intomainfrom Mar 27, 2026
Merged
refactor: switch admin ops from protobuf to binary encoding#10vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
remove protobuf dependency, generated proto files, and fila/v1 package. admin create_queue in test conftest now uses binary wire format (queue_len:u16 + queue + on_enqueue_len:u16 + on_failure_len:u16 + visibility_timeout_ms:u32). remove encode_admin helper from fibp.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobufruntime dependency and all generated proto files (fila/v1/,proto/)grpcio,grpcio-tools,mypy-protobuffrom dev dependenciescreate_queueto use binary wire format instead of protobuf serializationencode_adminhelper fromfibp.pyTest plan
python -c "import fila"succeeds (verified locally)Summary by cubic
Switch admin operations from protobuf payloads to a custom binary encoding to simplify the client and remove gRPC/protobuf dependencies. This reduces install size and removes all generated proto files.
Refactors
encode_adminand use_encode_framedirectly.fila/v1/and allproto/sources.create_queueto build the admin body in binary: queue_len:u16 + queue:utf8 + on_enqueue_len:u16 + on_failure_len:u16 + visibility_timeout_ms:u32.Dependencies
protobuf(runtime) and dev depsgrpcio,grpcio-tools,mypy-protobuf.pyproject.tomland removed mypy/ruff config tied to deleted modules.Written for commit 1f60ea5. Summary will update on new commits.