Skip to content

refactor: switch admin ops from protobuf to binary encoding#10

Merged
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding
Mar 27, 2026
Merged

refactor: switch admin ops from protobuf to binary encoding#10
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Mar 27, 2026

Summary

  • Remove protobuf runtime dependency and all generated proto files (fila/v1/, proto/)
  • Remove grpcio, grpcio-tools, mypy-protobuf from dev dependencies
  • Update test conftest create_queue to use binary wire format instead of protobuf serialization
  • Remove encode_admin helper from fibp.py

Test plan

  • python -c "import fila" succeeds (verified locally)
  • Integration tests pass against a FIBP server with binary admin encoding (PR #153)
  • No protobuf imports remain in the codebase

Summary by cubic

Switch admin operations from protobuf payloads to a custom binary encoding to simplify the client and remove gRPC/protobuf dependencies. This reduces install size and removes all generated proto files.

  • Refactors

    • Admin frames now use binary bodies; removed encode_admin and use _encode_frame directly.
    • Deleted generated modules under fila/v1/ and all proto/ sources.
    • Updated test create_queue to build the admin body in binary: queue_len:u16 + queue:utf8 + on_enqueue_len:u16 + on_failure_len:u16 + visibility_timeout_ms:u32.
  • Dependencies

    • Dropped protobuf (runtime) and dev deps grpcio, grpcio-tools, mypy-protobuf.
    • Cleaned pyproject.toml and removed mypy/ruff config tied to deleted modules.

Written for commit 1f60ea5. Summary will update on new commits.

remove protobuf dependency, generated proto files, and fila/v1 package.
admin create_queue in test conftest now uses binary wire format
(queue_len:u16 + queue + on_enqueue_len:u16 + on_failure_len:u16 +
visibility_timeout_ms:u32). remove encode_admin helper from fibp.py.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

@vieiralucas vieiralucas merged commit 3c12860 into main Mar 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant