feat: transparent leader hint reconnect on consume#2
Merged
vieiralucas merged 3 commits intomainfrom Mar 24, 2026
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="fila/client.py">
<violation number="1" location="fila/client.py:235">
P2: Close the existing gRPC channel before replacing it during redirect to avoid leaking connections.</violation>
</file>
<file name="fila/async_client.py">
<violation number="1" location="fila/async_client.py:245">
P1: Old gRPC channel is leaked on reconnect. `self._channel` is overwritten without closing the previous channel first, leaving its file descriptors and background tasks open until GC (if ever).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
38bf90c to
1f5753e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consumereceives gRPCUNAVAILABLEwithx-fila-leader-addrtrailing metadata, the client transparently reconnects to the leader address and retries onceClientand asyncAsyncClientTest plan
RPCErrorRPCError(no infinite loop)🤖 Generated with Claude Code
Summary by cubic
Automatically reconnects to the hinted leader and retry once when a consume call hits a follower. Works for both sync
ClientandAsyncClient, reuses TLS/mTLS credentials and API key, and closes the old channel before reconnecting.New Features
x-fila-leader-addrand retries consume against the leader once.RPCError.Bug Fixes
Written for commit 273746e. Summary will update on new commits.