[pull] master from flutter:master#1119
Merged
pull[bot] merged 7 commits intofakegit:masterfrom Nov 16, 2020
Merged
Conversation
* Added notificationListner sample code * Fixed spacing * fixed spacing * Moved the variables into the Build method * fixed typos * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com> * Update packages/flutter/lib/src/widgets/notification_listener.dart Co-authored-by: John Ryan <ryjohn@google.com>
…, mac, and windows (#70412) * Move web integration tool tests to web.shard Web integration tool tests depend on DDC changes in SDK. This change moves them to a separate shard and subshard so CI bot configurations can run them separately. In particular, with will allow running those tests on dart CI flutter HHH web bot instead of a non-web one, allowing early detection and easy classification of issues caused by SDK changes as VM- or Web related. * Enabled verbose mode for flaky web_tool_tests * fixed local engine crash with --enable-asserts * Disable failing tests, fix local engine with asserts * Removed mac web_tool_tests bot * Addressed CR comments * Add disabled mac web_tool_tests and disable win web_tool_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )