Skip to content

[pull] master from mozilla:master#124

Merged
pull[bot] merged 6 commits intofakegit:masterfrom
mozilla:master
Aug 27, 2020
Merged

[pull] master from mozilla:master#124
pull[bot] merged 6 commits intofakegit:masterfrom
mozilla:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Aug 27, 2020

See Commits and Changes for more details.


Created by pull[bot]. Want to support this open source service? Please star it : )

calixteman and others added 6 commits August 27, 2020 10:45
…hments in Firefox (bug 1661259)"

This reverts commit 1e5d4b6, since it unfortunately doesn't work in all situations.

Please note that I did *successfully* test the patch in a local Firefox build, obviously with an ad blocker installed.
However, I've now tested the *latest* Nightly-build with my default profile, and unfortunately I can still reproduce the bug there!?
…ntType when downloading PDF attachments

This should provide better filetype detection when downloading PDF attachments in the viewer.

Also, to avoid creating the "is PDF file" regular expression more than once it's extracted into a global constant instead.
…9, PR 12286 follow-up)

Unfortunately the work-around implemented in PR 12286 didn't actually work in all cases, please refer to the previous commit messages.
To prevent opening of PDF attachments from being completely broken for some users, we'll simply force-download them for now in MOZCENTRAL-builds to unbreak things. (Given that the "Open with" dialog now features a "Open with Firefox"-option, this is less bad than it previously would've been.)
Download, rather than opening, PDF attachments in Firefox (bug 1661259, PR 12286 follow-up)
Bug 1661226 - Push button are not rendered with renderInteractiveForms enabled
@pull pull bot added the ⤵️ pull label Aug 27, 2020
@pull pull bot merged commit eb3654e into fakegit:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants