Skip to content

test: remove mocks from address#285

Merged
Shinigami92 merged 4 commits intomainfrom
test-address-remove-mocks
Jan 30, 2022
Merged

test: remove mocks from address#285
Shinigami92 merged 4 commits intomainfrom
test-address-remove-mocks

Conversation

@Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Jan 24, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review January 24, 2022 22:04
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 24, 2022 22:04
@Shinigami92
Copy link
Member Author

I will add some missing cases

@Shinigami92 Shinigami92 marked this pull request as draft January 25, 2022 16:50
@Shinigami92
Copy link
Member Author

The non metric coords test is currently flaky

We also found that we maybe should set a random seed for the non-seed-based tests, cause otherwise it would take the last set seed sequence

@Shinigami92 Shinigami92 marked this pull request as ready for review January 27, 2022 12:34
@ST-DDT
Copy link
Member

ST-DDT commented Jan 27, 2022

Maybe remove the chore(deps): update vitest commit from this PR?

ST-DDT
ST-DDT previously approved these changes Jan 27, 2022
@Shinigami92
Copy link
Member Author

Maybe remove the chore(deps): update vitest commit from this PR?

I will rebase if #316 was merged

ST-DDT
ST-DDT previously approved these changes Jan 29, 2022
@ST-DDT ST-DDT requested a review from a team January 29, 2022 18:37
@ST-DDT ST-DDT requested a review from a team January 29, 2022 18:45
@Shinigami92 Shinigami92 merged commit 730ca6a into main Jan 30, 2022
@Shinigami92 Shinigami92 deleted the test-address-remove-mocks branch January 30, 2022 10:52
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants