Skip to content

test: use run for coverage#318

Merged
Shinigami92 merged 1 commit intomainfrom
coverage-run
Jan 28, 2022
Merged

test: use run for coverage#318
Shinigami92 merged 1 commit intomainfrom
coverage-run

Conversation

@Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior c: test labels Jan 27, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 27, 2022 08:03
@Shinigami92 Shinigami92 self-assigned this Jan 27, 2022
@Shinigami92 Shinigami92 requested a review from a team January 27, 2022 12:28
@griest024
Copy link
Contributor

why is this needed?

@ST-DDT
Copy link
Member

ST-DDT commented Jan 27, 2022

Otherwise it will stay it the watch mode and not output the coverage.
(At least, that's what my local tests showed me as diff)

@Shinigami92 Maintainers should still write a description with a summary/explanation for their changes.

@Shinigami92 Shinigami92 merged commit 7396a57 into main Jan 28, 2022
@Shinigami92 Shinigami92 deleted the coverage-run branch January 28, 2022 07:28
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior c: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants