docs: use html tables instead of md tables to account for ::: v-pre#330
Merged
JessicaSachs merged 3 commits intomainfrom Jan 28, 2022
Merged
docs: use html tables instead of md tables to account for ::: v-pre#330JessicaSachs merged 3 commits intomainfrom
JessicaSachs merged 3 commits intomainfrom
Conversation
Shinigami92
previously approved these changes
Jan 28, 2022
Member
Shinigami92
left a comment
There was a problem hiding this comment.
Tested it locally and it seems to work fine now
Shinigami92
reviewed
Jan 28, 2022
Shinigami92
approved these changes
Jan 28, 2022
JessicaSachs
approved these changes
Jan 28, 2022
bmenant
pushed a commit
to bmenant/faker
that referenced
this pull request
Mar 11, 2022
…aker-js#330) Co-authored-by: Jessica Sachs <jess@jessicasachs.io> Co-authored-by: Shinigami <chrissi92@hotmail.de>
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
…aker-js#330) Co-authored-by: Jessica Sachs <jess@jessicasachs.io> Co-authored-by: Shinigami <chrissi92@hotmail.de>
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
…aker-js#330) Co-authored-by: Jessica Sachs <jess@jessicasachs.io> Co-authored-by: Shinigami <chrissi92@hotmail.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to disable processing for parameters as well to avoid issues with potential examples
{{name.first_name}}in there.You can test this by adding a js like this:
Example output:
@Shinigami92
I decided to use
::: v-pre(with space) as used in the official documentation.I will split any "omit ::: v-pre if unnecessary" optimizations into later PRs.