Merged
Conversation
JessicaSachs
force-pushed
the
fix/remove-malformed-toc
branch
from
584b281 to
9773f7d
Compare
pkuczynski
reviewed
Jan 29, 2022
Shinigami92
reviewed
Jan 29, 2022
Member
Shinigami92
left a comment
Shinigami92
left a comment
There was a problem hiding this comment.
I'm okay for now with this change/removal of toc, because in the sidebar you can still the what functions are there.
Shinigami92
approved these changes
Jan 30, 2022
ST-DDT
approved these changes
Jan 30, 2022
bmenant
pushed a commit
to bmenant/faker
that referenced
this pull request
Mar 11, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
ST-DDT
modified the milestones:
v6 - Non-Breaking Changes,
v6.0 - Ensure Project Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the TOC from the codegen. It's okay. We'll improve the Docs UX shortly.
Should solve #327