Merged
Conversation
Member
Author
|
@damienwebdev We need to give the maintainers-docs group write access |
Codecov Report
@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1925 1924 -1
Lines 177002 176983 -19
Branches 909 904 -5
==========================================
- Hits 175849 175822 -27
- Misses 1097 1105 +8
Partials 56 56
|
ejcheng
approved these changes
Mar 25, 2022
Member
ejcheng
left a comment
There was a problem hiding this comment.
Besides the @faker-js/maintainers-docs write access issue, this LGTM!
Member
Author
|
Okay, let's wait on @damienwebdev and the write access for |
Member
Author
|
Beside the fact that the docs owners doesn't work as expected, it will not break when I merge this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

or-condition in a line)