Skip to content

chore: update codeowners file#671

Merged
Shinigami92 merged 5 commits intomainfrom
update-codeowners
Apr 1, 2022
Merged

chore: update codeowners file#671
Shinigami92 merged 5 commits intomainfrom
update-codeowners

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

  • Formatted the file a bit better
  • Added maintainers also to docs, so one of them is just required (codeowners file works with or-condition in a line)

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch labels Mar 25, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 25, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 25, 2022 08:06
@Shinigami92
Copy link
Copy Markdown
Member Author

Shinigami92 commented Mar 25, 2022

@damienwebdev We need to give the maintainers-docs group write access

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 25, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2022

Codecov Report

Merging #671 (128d3b4) into main (184e669) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 128d3b4 differs from pull request most recent head aafff3d. Consider uploading reports for the commit aafff3d to get more accurate results

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1925     1924       -1     
  Lines      177002   176983      -19     
  Branches      909      904       -5     
==========================================
- Hits       175849   175822      -27     
- Misses       1097     1105       +8     
  Partials       56       56              
Impacted Files Coverage Δ
src/name.ts 99.71% <0.00%> (-0.29%) ⬇️
src/system.ts 96.44% <0.00%> (-0.02%) ⬇️
src/address.ts 99.10% <0.00%> (-0.01%) ⬇️
src/random.ts 99.46% <0.00%> (-0.01%) ⬇️
src/finance.ts 99.30% <0.00%> (-0.01%) ⬇️
src/fake.ts 100.00% <0.00%> (ø)
src/word.ts 100.00% <0.00%> (ø)
src/faker.ts 100.00% <0.00%> (ø)
src/commerce.ts 100.00% <0.00%> (ø)
src/datatype.ts 100.00% <0.00%> (ø)
... and 9 more

Copy link
Copy Markdown
Member

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the @faker-js/maintainers-docs write access issue, this LGTM!

Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@ST-DDT ST-DDT requested a review from a team March 25, 2022 11:16
@Shinigami92 Shinigami92 added the do NOT merge yet Do not merge this PR into the target branch yet label Mar 25, 2022
@Shinigami92
Copy link
Copy Markdown
Member Author

Okay, let's wait on @damienwebdev and the write access for maintainers-docs

@Shinigami92
Copy link
Copy Markdown
Member Author

Beside the fact that the docs owners doesn't work as expected, it will not break when I merge this...
So I will do that now

@Shinigami92 Shinigami92 enabled auto-merge (squash) April 1, 2022 14:31
@Shinigami92 Shinigami92 removed the do NOT merge yet Do not merge this PR into the target branch yet label Apr 1, 2022
@Shinigami92 Shinigami92 merged commit a55d617 into main Apr 1, 2022
@ST-DDT ST-DDT deleted the update-codeowners branch April 2, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants