refactor(address): drop local references of faker modules#748
Merged
Shinigami92 merged 2 commits intofaker-js:mainfrom Apr 1, 2022
xDivisionByZerox:address-drop-internal-reuse-of-faker-modules
Merged
refactor(address): drop local references of faker modules#748Shinigami92 merged 2 commits intofaker-js:mainfrom xDivisionByZerox:address-drop-internal-reuse-of-faker-modules
Shinigami92 merged 2 commits intofaker-js:mainfrom
xDivisionByZerox:address-drop-internal-reuse-of-faker-modules
Conversation
xDivisionByZerox
added
p: 1-normal
Shinigami92
approved these changes
Apr 1, 2022
ejcheng
approved these changes
Apr 1, 2022
Member
Author
|
2 approvals before tests finish. GJ guys xD |
xDivisionByZerox
deleted the
address-drop-internal-reuse-of-faker-modules
branch
Member
|
I didn't have time to hit the approval button. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In favor of #683 discussion