refactor: remove inconsistent defaults from internet.password()#767
Merged
Shinigami92 merged 3 commits intomainfrom Apr 4, 2022
Merged
refactor: remove inconsistent defaults from internet.password()#767Shinigami92 merged 3 commits intomainfrom
Shinigami92 merged 3 commits intomainfrom
Conversation
ST-DDT
added
c: chore
Codecov Report
@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1918 1918
Lines 176479 176478 -1
Branches 914 908 -6
==========================================
- Hits 175322 175320 -2
- Misses 1101 1102 +1
Partials 56 56
|
Shinigami92
reviewed
Apr 3, 2022
ejcheng
added
c: refactor
ejcheng
approved these changes
Apr 4, 2022
Shinigami92
changed the title
Shinigami92
approved these changes
Apr 4, 2022
prisis
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaults in the password method are inconsistent, I consolidated them and removed useless lines.