Add Faker::Creature namespace#1424
Merged
vbrazo merged 7 commits intofaker-ruby:masterfrom Oct 21, 2018
Merged
Conversation
ChaoticBoredom
commented
Oct 20, 2018
| end | ||
|
|
||
| def gender | ||
| fetch('creature.dog.gender') |
Contributor
Author
There was a problem hiding this comment.
Found this a bit odd, would it make more sense to re-use Faker::Gender.binary_type here instead of having another set of identical data?
Member
There was a problem hiding this comment.
I think that's a great suggestion and you can go ahead and implement :)
vbrazo
changed the title
vbrazo
reviewed
Oct 20, 2018
| # Random dog size | ||
| Faker::Dog.size #=> "small" | ||
| ``` No newline at end of file | ||
| Faker::Creature::::Dog.size #=> "small" |
Member
There was a problem hiding this comment.
It should be Faker::Creature::Dog
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Migrate 'cat' to the 'creatures' namespace * Migrate 'dog' into the 'creature' namespace * Update references in README * Fix Dog class misxup * Fix extra '::' in documentation * Update dog.rb * Update dog.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the suggestion made by @SpyMaster356 in issue #1318, I've moved both
CatandDogfakers into theCreaturenamespace.I've deprecated the original methods, put tests in place for the deprecations, and moved the real classes and tests under the
creaturenamespace.