Add Aircraft Generators#1663
Closed
CuriousFurBytes wants to merge 12 commits intofaker-ruby:masterfrom
CuriousFurBytes:aircrafts
Closed
Add Aircraft Generators#1663CuriousFurBytes wants to merge 12 commits intofaker-ruby:masterfrom CuriousFurBytes:aircrafts
CuriousFurBytes wants to merge 12 commits intofaker-ruby:masterfrom
CuriousFurBytes:aircrafts
Conversation
added 12 commits
December 16, 2018 17:23
Fix Faker::Internet.ip_v4_address to include all IP ranges (#1494)
Merge stympy/faker into lucasqueiroz/faker
Merge stympy/faker into lucasqueiroz/faker
Update Faker::Games::SuperSmashBros entries (#1658)
This commit adds an Aircraft generator with manufacturers
Adds airlines from Africa and Americas Source: https://en.wikipedia.org/wiki/Lists_of_airlines
Add airlines from Asia, Europe and Oceania
a2a9f17 to
4384168
Compare
Contributor
|
Hey there. In an effort to lighten our load as maintainers and be able to serve you better in the future, the faker-ruby team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this PR. Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised. If you feel that we should reopen this PR, please do the following first:
Then please let us know so that we can re-prioritize it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request adds an aircraft generator, including Manufacturers, Models (by manufacturer), Prefixes and Airlines. It includes the United States prefixes as well as the Brazilian ones.
I have included only the most famous manufacturers and only the passenger jets.
References: