Skip to content

Amend province for zh-CN#3229

Open
ccmywish wants to merge 1 commit intofaker-ruby:mainfrom
ccmywish:province-zh-cn
Open

Amend province for zh-CN#3229
ccmywish wants to merge 1 commit intofaker-ruby:mainfrom
ccmywish:province-zh-cn

Conversation

@ccmywish
Copy link

@ccmywish ccmywish commented Mar 17, 2026

Motivation / Background

In China, we use province instead of state. In the original localization, the default term state was used.

To address this, I adjusted it to province and used the standard term of each province rather than an abbreviation.

However, there is an issue with this PR: to maintain backward compatibility, I used YAML's anchor syntax. What do you think — is this necessary?

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant