Add gendered first names to it and fr-CH locales#3270
Open
huerlisi wants to merge 1 commit into
Open
Conversation
`Faker::Name.male_first_name` and `female_first_name` had no data in the `it` and `fr-CH` locales, so they silently fell back to the English name list (e.g. `it` returned "Barton"/"Tanesha", `fr-CH` returned "Antonia"/"Hermina"). Add curated, sex-correct `male_first_name`/`female_first_name` pools to both locales. The change is purely additive: the existing gender-neutral `first_name` lists are left untouched. Tests assert the generated names are members of the locale's own lists, guarding against a regression back to the English fallback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
I've created three MRs to add some specific locale data we need in our application. The MRs touch the same files, so this could lead to conflicts. I can also rework them into a single MR if that's simpler. I've created these MRs using Claude Code but manually verified. I kept the markers in the commit message. Just tell what your policy regarding AI supported contributions are if this does not work for you. Thanks for maintaining this gem <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Faker::Name.male_first_nameandFaker::Name.female_first_namehad nodata in the
itandfr-CHlocales. Because of that they silently fellback to the English name list, so a German/Italian/French app asking for a
gendered first name got English names:
This Pull Request adds curated, sex-correct
male_first_name/female_first_namepools to both locales. The change is purely additive:the existing gender-neutral
first_namelists are left untouched, so noexisting behaviour changes.
Additional information
Output after the change:
The added tests assert the generated names are members of the locale's own
lists, guarding against a regression back to the English fallback.
Checklist