Changes Hipster methods to use named parameters to improve readability.#742
Closed
tiagofsilva wants to merge 1 commit intofaker-ruby:masterfrom
Closed
Changes Hipster methods to use named parameters to improve readability.#742tiagofsilva wants to merge 1 commit intofaker-ruby:masterfrom
tiagofsilva wants to merge 1 commit intofaker-ruby:masterfrom
Conversation
Contributor
|
I'm going to hold off on this one until I'm ready for a major release to break backwards compatibility. In that release we'll change everything to use named parameters. |
Contributor
Author
|
Great, @stympy! Knowing that, I'll be working on changing more classes to named parameters then. |
a359def to
a5d7731
Compare
Closed
Member
|
Since we're migrating the objects to namespaces #1318, we'll change the arguments to keywords/named params while adding the namespaces. I think it'd be a better idea to concentrate all the changes in this transition instead of doing things separately. Thanks for opening this PR and suggesting this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hipsterclass.