fix(agent): skip site dirs that have bad .pth files#167
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses an issue with .pth files by adding error handling in site directory loading.
- Introduces a try/except block around site.addsitedir to skip problematic directories.
- Adds traceback and error notification output for debugging purposes.
| # packages. | ||
| for site_dir in python_path.split(os.pathsep): | ||
| site.addsitedir(site_dir) | ||
| try: |
There was a problem hiding this comment.
Consider using a logging framework instead of print and traceback for error reporting. This change would improve log aggregation and production diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.pthcould be model weights or python path configuration files https://docs.python.org/3/library/site.html Running into the former will result in:So we are now just skipping such dirs. There is a risk that we might miss some useful pth files, but I doubt there will ever be a situation where two are mixed.