Conversation
… with official terminology Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
kind/documentation
Contributor
|
LGTM label has been added. DetailsGit tree hash: 40616a4781df45ac723af264f12db174a470fd62 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com
What type of PR is this?
/kind documentation
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This PR updates the k8saudit plugin and allows configuring the event size of each event. This solves a problem where the plugin terminates with
io.ErrShortWritedue to the underlying allocated event batch being too small for the event coming from the webhook backend. Accordingly, the max event and batch size have been renamed in the init config to resemble the terminology of the k8s docs(--audit-webhook-truncate-max-batch-size,--audit-webhook-truncate-max-event-size): https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/Which issue(s) this PR fixes:
Special notes for your reviewer: