Skip to content

fix(reusable-burndown): declare JF_CI_GH_PAT in workflow_call secrets#305

Merged
jdfalk merged 1 commit into
mainfrom
fix/burndown-jf-ci-pat-secret
Jun 10, 2026
Merged

fix(reusable-burndown): declare JF_CI_GH_PAT in workflow_call secrets#305
jdfalk merged 1 commit into
mainfrom
fix/burndown-jf-ci-pat-secret

Conversation

@jdfalk

@jdfalk jdfalk commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Problem

secrets.JF_CI_GH_PAT is referenced in 4 container credential blocks but not declared in on.workflow_call.secrets. GitHub validates reusable workflow secrets at parse time, so callers (e.g. nightly-burndown.yml) fail with 'workflow file issue'.

Fix

Add JF_CI_GH_PAT: required: false to the secrets block. actionlint passes cleanly after this change.

secrets.JF_CI_GH_PAT was used in 4 container credential blocks but
was not declared in on.workflow_call.secrets, causing GitHub Actions
to reject the workflow with a validation error. All callers
(nightly-burndown.yml in every repo) fail with 'workflow file issue'.

Add JF_CI_GH_PAT as optional so callers can pass secrets: inherit
and fall back to GITHUB_TOKEN when the PAT is absent.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jdfalk jdfalk merged commit 0484dec into main Jun 10, 2026
7 of 9 checks passed
@jdfalk jdfalk deleted the fix/burndown-jf-ci-pat-secret branch June 10, 2026 12:55
@github-actions github-actions Bot added size/XS github-actions GitHub Actions related work module:config Configuration management workflow:github-actions GitHub Actions workflows labels Jun 10, 2026
jdfalk added a commit that referenced this pull request Jun 10, 2026
Records v1.11.1 (JF_CI_GH_PAT secret declaration, PR #305) and
v1.11.2 (runner image ob-18f0014 removing broken ContextManagement
param, PR #306).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions GitHub Actions related work module:config Configuration management size/XS workflow:github-actions GitHub Actions workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant