feat: chip-based ticker editor#17
Merged
Merged
Conversation
Replace the raw tickers textarea in Configure with a proper editor: existing tickers show as removable chips (× to delete), and an input + Add button (Enter or comma to add) appends new symbols — uppercased, sanitised, deduped, capped at 16. Much nicer than editing a comma blob. Frontend-only; tsc clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the settings “Tickers” editor from a freeform textarea to a chip-based UI for adding/removing symbols, and adds supporting styles.
Changes:
- Replaces ticker textarea parsing with an interactive chip editor (add/remove, max 16).
- Adds new CSS rules for ticker chip layout and controls.
- Updates focus behavior to target the new ticker input.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| public/app.css | Adds styling for the new ticker chip editor UI. |
| public/actions.js | Implements chip-based ticker editing and updates settings save payload. |
| frontend/actions.ts | TypeScript equivalent of the chip editor and updated save behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+92
to
+95
| chipsEl.addEventListener('click', (event) => { | ||
| const btn = event.target.closest('[data-remove-ticker]'); | ||
| if (!btn) | ||
| return; |
Comment on lines
+85
to
+87
| chipsEl.addEventListener('click', (event: MouseEvent) => { | ||
| const btn = (event.target as HTMLElement).closest<HTMLButtonElement>('[data-remove-ticker]'); | ||
| if (!btn) return; |
Comment on lines
+96
to
+97
| editTickers.splice(Number(btn.dataset.removeTicker), 1); | ||
| renderChips(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the ticker-adding UX in Configure.
Replaces the raw comma/newline textarea with a proper editor:
Verified: typing
pltradds aPLTRchip; chips render + remove cleanly (screenshot).Frontend-only;
tscclean.🤖 Generated with Claude Code