UI: fix duplicate stop icon, wire the icon legend, + terminal/mobile copy improvements#32
Merged
Merged
Conversation
The composer toolbar rendered the same octagon-X icon for both "Ctrl-C interrupt" and "Stop tmux session" — two identical orange buttons, one of which kills the whole session. Give Stop-session a distinct power icon, clarify its label as destructive, and add a confirm() guard. The "Button legend" was also dead code (defined, never called), so it never mounted. Wire buildLegend() into renderShellTabs() and complete it: all 13 composer buttons (adds Mic/Stop-session/Shell-in/Resume) plus the running/waiting dots. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Phase 1 of a UI clarity pass: disambiguates the previously-duplicate "stop" button in the composer toolbar (Ctrl-C interrupt vs. kill tmux session), adds a confirmation guard to the destructive action, and wires up the legend so it actually renders with all 13 composer icons.
Changes:
- Replace the second
stopicon with a newpowericon for "kill tmux session", retitle/relabel it as destructive, and gate it behindconfirm(). - Call
buildLegend()fromrenderShellTabs()so the legend mounts; expand the legend with previously-missing rows (Mic, Stop session, Shell-in, Resume) and clarify Ctrl-C wording. - Add a
powerSVG entry to theICONSmap.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/core.ts | Adds power icon to the ICONS map. |
| public/core.js | Compiled counterpart adding power icon. |
| frontend/render.ts | Swaps stop→power for kill-session button; calls buildLegend(); expands legend rows. |
| public/render.js | Compiled counterpart of render.ts changes. |
| frontend/events.ts | Adds confirm() guard before kill-session API call. |
| public/events.js | Compiled counterpart of events.ts change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Live terminal (xterm.js): add Copy-all-scrollback alongside the selection copy — a titlebar button and, crucially, Copy/All/Paste keys in the mobile key bar, since xterm touch-selection is unusable on a phone. copyTerminalAll() selectAll → copy → clearSelection with char- count feedback. The text keys span two grid cells so they never clip. Composer: copyShellOutput now copies the user's text selection when one exists inside that card, falling back to the whole pane output. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The composer shows 13 icons; on a phone it is hidden entirely (the mobile UX is the tab switcher + full-screen terminal), so the crowding is really a desktop concern. Fold the rare/destructive actions — Clear-view, Shell-in, and Stop-session — behind a ⋯ "More" toggle so the everyday row is ten icons. A nice side effect: the destructive Stop-session now sits behind an extra click, and the default row shows only one warn icon (Ctrl-C), reinforcing the Phase 1 disambiguation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Feedback round on the UI work: - Shell-in is used a lot, so move it back to the primary toolbar row; only Clear-view and Stop-session stay behind the ⋯ overflow. - Add a "Legend" button right next to the live-time pill that toggles the collapsible legend, and expand the legend with a Toolbar section (Focus/Grid, Lines 80/200/500, Follow, Summary, Refresh) so the cryptic header controls — especially the "80" dropdown — are explained. - Live time and the "updated" pill now render 24-hour. - The line-count dropdown reads "80 lines / 200 lines / 500 lines" with a tooltip instead of a bare "80". - Hide the ticker strip entirely on phones (≤760px); it was just noise above the shells. The legend stays collapsible on mobile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI-clarity + copy + toolbar declutter for ShellDeck. Squash-merge when ready.
Phase 1 — fix the duplicate stop icon + wire the legend
Phase 2 — better copy in the live (xterm.js) terminal
Phase 3 — smarter composer copy
Phase 4 — declutter the composer toolbar (reframed during verification)
"mobile UI skill" research → VoltAgent/awesome-agent-skills → anthropics/frontend-design (already available locally; applied here). ShellDeck's real mobile surface is the terminal, improved in Phase 2.
All phases tsc-clean and browser-verified (desktop + 390px) against real tmux sessions.
Generated with Claude Code