Reclaim top-bar room: inline tickers, drop redundant pills, gate Safe shot#48
Merged
Conversation
… shot
- Move the ticker bar into the top bar next to the wordmark (scrolls
horizontally) — reclaims its whole separate row.
- Remove the always-true "dashboard signed in" pill; show the access
pill only when shells are LOCKED (hide the redundant "shells unlocked"
via .access-pill.on{display:none}).
- Gate the "Safe shot" button behind DASHBOARD_ENABLE_SAFE_SHOT
(env_flag, default off) — config.enable_safe_shot conditionally
renders the button in pages.rs.
Verified live: tickers inline, authState/safeShotBtn absent, refresh +
sign-out intact, build green, console clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reclaims vertical space in the dashboard header by moving the ticker strip into the top bar, removing redundant status UI, and gating the “Safe shot” action behind a new config/env flag.
Changes:
- Restructures the dashboard header layout to inline the ticker strip within the top bar.
- Removes the redundant “dashboard signed in” pill and hides the “shells unlocked” access pill via CSS.
- Adds
DASHBOARD_ENABLE_SAFE_SHOT/config.enable_safe_shotto conditionally render the Safe shot button.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages.rs | Reorders header markup (tickers inline) and conditionally renders the Safe shot button. |
| src/config.rs | Introduces enable_safe_shot config flag sourced from DASHBOARD_ENABLE_SAFE_SHOT. |
| public/app.css | Adds topbar-specific ticker strip styling and hides the “unlocked” access pill state. |
| frontend/prefs.ts | Removes now-dead UI update for the removed #authState element. |
| public/prefs.js | Removes now-dead UI update for the removed #authState element (built output). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+65
| // "Safe shot" generates a shareable, redacted screenshot. Off by default; set | ||
| // DASHBOARD_ENABLE_SAFE_SHOT=1 to show the top-bar button. | ||
| pub enable_safe_shot: bool, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclaim vertical room in the header.
.access-pill.on{display:none}).DASHBOARD_ENABLE_SAFE_SHOT(default off) —config.enable_safe_shotconditionally renders the button. Set the env to1to show it.Pure-ish:
config.rs(flag) +pages.rs(header restructure + conditional button) +app.css(inline tickers, hide-unlocked pill) +prefs.ts(drop dead authState line).Verified live (1600px)
Tickers inline next to the wordmark,
authState/safeShotBtnabsent, Refresh + Sign out intact, build green, console clean.🤖 Generated with Claude Code