max refresh token duration #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-famedly
requested changes
Feb 12, 2025
Contributor
jason-famedly
left a comment
jason-famedly
left a comment
There was a problem hiding this comment.
Other than a comment fix, looks great!
This amends 05b8fc1. You can now specify a maximum duration for the refresh token lifetime to be used with the custom `com.famedly.refresh_token_lifetime_ms` parameter. This clamps any values passed via the API to be lower or equal of this maximum specified via `famedly_maximum_refresh_token_lifetime` in the config.
nico-famedly
force-pushed
the
nico/max-refresh-token-duration
branch
from
71dbb3f to
2fd9472
Compare
nico-famedly
added a commit
that referenced
this pull request
Feb 18, 2025
This amends 05b8fc1. You can now specify a maximum duration for the refresh token lifetime to be used with the custom `com.famedly.refresh_token_lifetime_ms` parameter. This clamps any values passed via the API to be lower or equal of this maximum specified via `famedly_maximum_refresh_token_lifetime` in the config.
nico-famedly
added a commit
that referenced
this pull request
Feb 26, 2025
This amends 05b8fc1. You can now specify a maximum duration for the refresh token lifetime to be used with the custom `com.famedly.refresh_token_lifetime_ms` parameter. This clamps any values passed via the API to be lower or equal of this maximum specified via `famedly_maximum_refresh_token_lifetime` in the config.
nico-famedly
added a commit
that referenced
this pull request
Mar 26, 2025
This amends 05b8fc1. You can now specify a maximum duration for the refresh token lifetime to be used with the custom `com.famedly.refresh_token_lifetime_ms` parameter. This clamps any values passed via the API to be lower or equal of this maximum specified via `famedly_maximum_refresh_token_lifetime` in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends 05b8fc1.
You can now specify a maximum duration for the refresh token lifetime to be used with the custom
com.famedly.refresh_token_lifetime_msparameter. This clamps any values passed via the API to be lower or equal of this maximum specified viafamedly_maximum_refresh_token_lifetimein the config.Fixes https://github.com/famedly/product-management/issues/2827