Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates ConnectKit’s “Family Accounts” integration to use the new @aave/account package and introduces corresponding Aave Account-facing connector IDs and UI copy as part of the brand change.
Changes:
- Replaces the
familydependency with@aave/accountand wires it intodefaultConnectors/defaultConfig. - Adds Aave Account connector detection helpers/hooks and updates the connectors page CTA to “Continue with Aave”.
- Adds an
aaveAccountProviderwallet config entry and updates the en-US locale key for the CTA.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds @aave/account lock entry and removes family. |
| packages/connectkit/package.json | Swaps dependency from family to @aave/account. |
| packages/connectkit/src/defaultConnectors.ts | Uses aaveAccountConnector and exposes enableAaveAccount/aaveAccountOptions. |
| packages/connectkit/src/defaultConfig.ts | Renames config props to Aave Account equivalents and defaults Aave Account enabled. |
| packages/connectkit/src/hooks/useConnectors.ts | Adds useAaveAccountConnector() hook. |
| packages/connectkit/src/utils/index.ts | Adds isAaveAccountConnector() helper. |
| packages/connectkit/src/wallets/walletConfigs.tsx | Adds aaveAccountProvider wallet metadata. |
| packages/connectkit/src/components/Pages/Connectors/index.tsx | Replaces Family Accounts CTA with “Continue with Aave” flow. |
| packages/connectkit/src/components/Common/ContinueWithAaveButton/index.tsx | Renames button component and switches locale key used for CTA text. |
| packages/connectkit/src/components/Common/ContinueWithAaveButton/styles.ts | Normalizes relative import path. |
| packages/connectkit/src/components/Common/ConnectorList/index.tsx | Filters out the Aave Account connector from the selectable wallet list. |
| packages/connectkit/src/localizations/locales/en-US.ts | Renames continueWithFamily to continueWithAave. |
Comments suppressed due to low confidence (1)
packages/connectkit/src/components/Common/ContinueWithAaveButton/index.tsx:40
- The button text is updated to “Continue with Aave”, but the rendered icon is still
FamilyLogo. This creates a visible branding mismatch; update the icon used here to the Aave Account mark (or otherwise align the visual with the new label).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/connectkit/src/components/Common/ConnectorList/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
packages/connectkit/src/components/Common/ContinueWithAaveButton/styles.ts:20
- The hover styling currently sets
--hover-backgroundto the same value as--background, so the button won’t visually change on hover. Since the theme defines--ck-aave-brand-hover, consider using that for--hover-background(or remove the unused hover token) so hover state matches the intended design.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/connectkit/src/components/Common/ConnectorList/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 33 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/connectkit/src/components/Common/ContinueWithAaveButton/styles.ts:20
- Hover styling currently doesn’t use the new
--ck-aave-brand-hovertoken (and--hover-backgroundis set to the same value as--background), so the button won’t visually change on hover and the hover token remains unused. Point--hover-backgroundtovar(--ck-aave-brand-hover)(or remove the unused token) so hover behavior is consistent and configurable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 33 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ctkit into update/aave-account
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 33 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packages/connectkit/src/components/Common/ContinueWithAaveButton/styles.ts:20
--ck-aave-brand-hoveris defined globally, but this button’s hover state uses--ck-aave-brandagain, so there’s no visual hover differentiation. Consider using the dedicated hover token (or remove it) so theming stays consistent and hover styling is intentional.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ios: 'https://apps.apple.com/us/app/dawn-ethereum-wallet/id1673143782', | ||
| }, | ||
| }, | ||
| 'co.family.wallet': { |
No description provided.