Skip to content

fix: dependabot warnings#504

Merged
lochie merged 5 commits intomainfrom
fix/dependabot
Mar 27, 2026
Merged

fix: dependabot warnings#504
lochie merged 5 commits intomainfrom
fix/dependabot

Conversation

@lochie
Copy link
Copy Markdown
Member

@lochie lochie commented Mar 27, 2026

Package Before After Dependabot #
rollup 2.79.2 2.80.0 #266
serialize-javascript 4.0.0 7.0.3 #273
minimatch 3.1.2 3.1.4 #264
underscore 1.12.1 1.13.8 #274
next 14.2.32 15.5.14 #242

Copilot AI review requested due to automatic review settings March 27, 2026 12:53
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
connectkit-nextjs Ready Ready Preview, Comment Mar 27, 2026 2:21pm
connectkit-testbench Ready Ready Preview, Comment Mar 27, 2026 2:21pm
connectkit-vite Ready Ready Preview, Comment Mar 27, 2026 2:21pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Dependency Review

The following issues were found:

  • ❌ 1 vulnerable package(s)

View full job summary

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address Dependabot security warnings in the monorepo by updating tooling dependencies and enforcing patched transitive versions via Yarn resolutions/lockfile updates.

Changes:

  • Bump rollup devDependency from ^2.79.2 to ^2.80.0.
  • Add Yarn resolutions overrides for serialize-javascript@7.0.3 and minimatch@3.1.3.
  • Update yarn.lock accordingly (including workspace entry and dependency graph changes).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Updates build tooling version and adds resolutions pins intended to remediate vulnerable transitive deps.
yarn.lock Regenerates/adjusts lock entries to reflect the new rollup version and enforced resolutions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

examples/testbench/package.json:20

  • This workspace now uses next 15.5.14, but eslint-config-next is still pinned to 14.1.0 in devDependencies. Consider aligning them (or otherwise validating lint config compatibility) to avoid unexpected lint/ruleset mismatches.
    "next": "15.5.14",
    "react": "^18.0.0",
    "react-dom": "^18.0.0",
    "viem": "^2.23.2",
    "wagmi": "^2.14.11"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 12 to 16
"connectkit": "workspace:packages/connectkit",
"connectkit-next-siwe": "workspace:packages/connectkit-next-siwe",
"next": "14.2.32",
"next": "15.5.14",
"react": "^18.0.0",
"react-dom": "^18.0.0",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example updates to next@15.5.14, but keeps eslint-config-next on 12.3.0 (and thus @next/eslint-plugin-next@12.3.0). That combination is likely to produce incorrect or failing next lint behavior. Update eslint-config-next to a compatible v15 release for this workspace when bumping Next major versions.

Copilot uses AI. Check for mistakes.
Comment on lines 22 to 26
"@types/react": "^18.2.43",
"eslint": "^8.15.0",
"eslint-config-next": "^14.0.4",
"next": "^14.2.32",
"next": "^15.5.14",
"typescript": "^5.0.4"
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workspace is now on next@15.5.14 but eslint-config-next remains on a v14 range. To keep next lint aligned with the installed Next major, update eslint-config-next to a v15 release in this workspace as well.

Copilot uses AI. Check for mistakes.
@@ -22,7 +22,7 @@
"@types/react": "^18.2.43",
"eslint": "^8.15.0",
"eslint-config-next": "^14.0.4",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workspace is now on next@15.5.14 but eslint-config-next remains on a v14 range. To keep next lint aligned with the installed Next major, update eslint-config-next to a v15 release in this workspace as well.

Suggested change
"eslint-config-next": "^14.0.4",
"eslint-config-next": "^15.0.0",

Copilot uses AI. Check for mistakes.
Comment on lines 14 to 17
"connectkit-next-siwe": "workspace:packages/connectkit-next-siwe",
"local-ssl-proxy": "^1.3.0",
"next": "14.2.32",
"next": "15.5.14",
"react": "^18.0.0",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example now depends on next@15.5.14 but keeps eslint-config-next@14.1.0. Consider bumping eslint-config-next to a v15 release here too so next lint uses rules/plugins that match the installed Next major version.

Copilot uses AI. Check for mistakes.
@lochie lochie merged commit 025b3f4 into main Mar 27, 2026
9 checks passed
@lochie lochie deleted the fix/dependabot branch March 27, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants