fix: deduplicate injected connector when EIP-6963 wallet is detected#507
Open
tenderdeve wants to merge 1 commit into
Open
fix: deduplicate injected connector when EIP-6963 wallet is detected#507tenderdeve wants to merge 1 commit into
tenderdeve wants to merge 1 commit into
Conversation
When a user configures an injected connector (e.g. Bitget Wallet) and the wallet's browser extension is also installed, both the generic injected connector and the EIP-6963 auto-detected connector appear in the modal. Remove the generic injected entry when a richer EIP-6963 connector for the same wallet is present. Fixes family#430
|
@tenderdeve is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injected()connector (e.g. Bitget Wallet) and the wallet's browser extension is also installed, both the generic injected connector (id: 'injected') and the EIP-6963 auto-detected connector (id: 'com.bitget.wallet') appear in the modal as duplicatesinjectedconnector when a richer EIP-6963 connector is already present, following the same pattern used for Coinbase Wallet and MetaMask dedupFile:
packages/connectkit/src/wallets/useWallets.tsxFixes #430
Test plan