Skip to content

Stacking window 'message' event listeners #682

@ExileofAranei

Description

@ExileofAranei

Describe the bug

Hi, just noticed that Html plugin does not remove it's listener for message event, plugin's detach function is not called on fancybox destroy so window.removeEventListener is also never called. It tends to adding listeners for such event on each fancybox opening. Sure it won't cause serious performance issues, but it worths mentioning anyway

Tested on my websites with latest version, screenshot is captured on yours
image

Reproduction

Open fancybox multiple times and check listeners for message event

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs triageThis issue has not been triaged by maintainers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions